Skip to content

Preserve inactive ProgressiveContainer positions - #23

Merged
syjn99 merged 1 commit into
mainfrom
fix/prog-inactive-positions
Oct 26, 2026
Merged

syjn99 merged 1 commit into
mainfrom
fix/prog-inactive-positions

Conversation

@syjn99

@syjn99 syjn99 commented Oct 15, 2026

Copy link
Copy Markdown
Member

Emit a zero chunk for each inactive position to keep later fields at their correct tree positions. Use tree positions in generated comments and update the golden file.

@syjn99
syjn99 added this pull request to stack #24 October 15, 2026 07:56
syjn99 added a commit to OffchainLabs/prysm that referenced this pull request Oct 15, 2026
…tions as zero leaves

Only bumps methodical-ssz to `c339c8abe71d`:
OffchainLabs/methodical-ssz#23

No behavior change, only comment for each SSZ files changed. This is needed as we are soon introducing inactive fields in EIP-8015.
@syjn99
syjn99 force-pushed the fix/prog-inactive-positions branch from c339c8a to f6e90c0 Compare October 15, 2026 13:46
syjn99 added a commit to OffchainLabs/prysm that referenced this pull request Oct 15, 2026
…tions as zero leaves

Only bumps methodical-ssz to `f6e90c07f759`:
OffchainLabs/methodical-ssz#23

No behavior change, only comment for each SSZ files changed. This is needed as we are soon introducing inactive fields in EIP-8015.
syjn99 added a commit to OffchainLabs/prysm that referenced this pull request Oct 19, 2026
…tions as zero leaves

Only bumps methodical-ssz to `f6e90c07f759`:
OffchainLabs/methodical-ssz#23

No behavior change, only comment for each SSZ files changed. This is needed as we are soon introducing inactive fields in EIP-8015.
syjn99 added a commit to OffchainLabs/prysm that referenced this pull request Oct 20, 2026
…tions as zero leaves

Only bumps methodical-ssz to `f6e90c07f759`:
OffchainLabs/methodical-ssz#23

No behavior change, only comment for each SSZ files changed. This is needed as we are soon introducing inactive fields in EIP-8015.
nalepae pushed a commit to OffchainLabs/prysm that referenced this pull request Oct 20, 2026
…tions as zero leaves

Only bumps methodical-ssz to `f6e90c07f759`:
OffchainLabs/methodical-ssz#23

No behavior change, only comment for each SSZ files changed. This is needed as we are soon introducing inactive fields in EIP-8015.
Base automatically changed from enforce-soft-unmarshal-limits to main October 26, 2026 08:57
@syjn99
syjn99 force-pushed the fix/prog-inactive-positions branch from f6e90c0 to 8cdabde Compare October 26, 2026 08:57
@syjn99
syjn99 merged commit bcebf66 into main Oct 26, 2026
6 checks passed
@syjn99
syjn99 deleted the fix/prog-inactive-positions branch October 26, 2026 08:59
syjn99 added a commit to syjn99/prysm that referenced this pull request Oct 29, 2026
**What does this PR do? Why is it needed?**

This PR updates `methodical-ssz` version to
[`c3f77ce44447`](https://github.com/OffchainLabs/methodical-ssz/tree/c3f77ce4444791c8d75cb950c8324f482ebebbed)
which includes these three PRs:

- OffchainLabs/methodical-ssz#22: Mostly worked
by Kasey on Progression merkleization support. This version is already
used in our production path (`932cc738`).
- OffchainLabs/methodical-ssz#23: Needed for
EIP-8015 and Decoupled consensus work. This fixes an issue when we have
"inactive" fields in the progressive container.
- OffchainLabs/methodical-ssz#21: Unlocks SSZ
Engine work.

**Which issue does this PR fix?**

N/A

**Other notes for review**

The diff in this PR, except dependency changes, is ALL comment changes.
Now generated codes for computing HTR of the progressive container
denote `Field` to `Position` which is much more accurate. No functional
changes intended as there is no "inactive" fields in Fulu/Gloas.

**Acknowledgement**

- [x] I have read
[CONTRIBUTING.md](https://github.com/OffchainLabs/prysm/blob/develop/CONTRIBUTING.md)
and my PR follows its checklist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants